From bb87bd3743c5f585642403d94e051bf90af14d09 Mon Sep 17 00:00:00 2001 From: Kyle Pope Date: Mon, 23 Feb 2026 03:07:06 +0800 Subject: [PATCH] Fix issues from QA review: cache invalidation, model server_default, route comment - Add ['tracked-tasks'] cache invalidation to toggle mutations in ProjectDetail and ProjectCard so dashboard widget stays fresh - Add server_default=sa.false() to model for consistency with migration - Add route ordering comment above /tracked-tasks endpoint Co-Authored-By: Claude Opus 4.6 --- backend/app/models/project.py | 3 ++- backend/app/routers/projects.py | 1 + frontend/src/components/projects/ProjectCard.tsx | 1 + frontend/src/components/projects/ProjectDetail.tsx | 1 + 4 files changed, 5 insertions(+), 1 deletion(-) diff --git a/backend/app/models/project.py b/backend/app/models/project.py index 1ebdbce..57b0969 100644 --- a/backend/app/models/project.py +++ b/backend/app/models/project.py @@ -1,3 +1,4 @@ +import sqlalchemy as sa from sqlalchemy import Boolean, String, Text, Date, func from sqlalchemy.orm import Mapped, mapped_column, relationship from datetime import datetime, date @@ -14,7 +15,7 @@ class Project(Base): status: Mapped[str] = mapped_column(String(20), default="not_started") color: Mapped[Optional[str]] = mapped_column(String(20), nullable=True) due_date: Mapped[Optional[date]] = mapped_column(Date, nullable=True) - is_tracked: Mapped[bool] = mapped_column(Boolean, default=False) + is_tracked: Mapped[bool] = mapped_column(Boolean, default=False, server_default=sa.false()) created_at: Mapped[datetime] = mapped_column(default=func.now()) updated_at: Mapped[datetime] = mapped_column(default=func.now(), onupdate=func.now()) diff --git a/backend/app/routers/projects.py b/backend/app/routers/projects.py index f0a89f4..0728e04 100644 --- a/backend/app/routers/projects.py +++ b/backend/app/routers/projects.py @@ -58,6 +58,7 @@ async def get_projects( return projects +# This route MUST be defined before /{project_id} to avoid path parameter shadowing @router.get("/tracked-tasks", response_model=List[TrackedTaskResponse]) async def get_tracked_tasks( days: int = Query(7, ge=1, le=90), diff --git a/frontend/src/components/projects/ProjectCard.tsx b/frontend/src/components/projects/ProjectCard.tsx index 4d79001..40d53bf 100644 --- a/frontend/src/components/projects/ProjectCard.tsx +++ b/frontend/src/components/projects/ProjectCard.tsx @@ -42,6 +42,7 @@ export default function ProjectCard({ project }: ProjectCardProps) { }, onSuccess: () => { queryClient.invalidateQueries({ queryKey: ['projects'] }); + queryClient.invalidateQueries({ queryKey: ['tracked-tasks'] }); toast.success(project.is_tracked ? 'Project untracked' : 'Project tracked'); }, onError: () => { diff --git a/frontend/src/components/projects/ProjectDetail.tsx b/frontend/src/components/projects/ProjectDetail.tsx index bae2055..14c75e0 100644 --- a/frontend/src/components/projects/ProjectDetail.tsx +++ b/frontend/src/components/projects/ProjectDetail.tsx @@ -196,6 +196,7 @@ export default function ProjectDetail() { onSuccess: () => { queryClient.invalidateQueries({ queryKey: ['projects'] }); queryClient.invalidateQueries({ queryKey: ['projects', id] }); + queryClient.invalidateQueries({ queryKey: ['tracked-tasks'] }); toast.success(project?.is_tracked ? 'Project untracked' : 'Project tracked'); }, onError: () => {