rohskiddo/UMBRA
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Fix crash when creating new todo/reminder/event (null.priority)

Browse Source 
All three DetailPanel components initialized isEditing=false even
when isCreating=true. The useEffect that flips it to true runs AFTER
the first render, so the view-mode branch executes with todo=null,
crashing on null.priority. Initialize isEditing from isCreating.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Kyle 2026-02-27 08:35:31 +08:00
parent 0fc3f1a14b
commit f07ce02576
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/src/components/calendar/EventDetailPanel.tsx
View File

@ -232,7 +232,7 @@ export default function EventDetailPanel({
staleTime: 5 * 60 * 1000, staleTime: 5 * 60 * 1000,
}); });
const [isEditing, setIsEditing] = useState(false); const [isEditing, setIsEditing] = useState(isCreating);
const [editState, setEditState] = useState<EditState>(() => const [editState, setEditState] = useState<EditState>(() =>
isCreating isCreating
? buildCreateState(createDefaults ?? null, defaultCalendar?.id?.toString() || '') ? buildCreateState(createDefaults ?? null, defaultCalendar?.id?.toString() || '')

2
frontend/src/components/reminders/ReminderDetailPanel.tsx
View File

@ -70,7 +70,7 @@ export default function ReminderDetailPanel({
}: ReminderDetailPanelProps) { }: ReminderDetailPanelProps) {
const queryClient = useQueryClient(); const queryClient = useQueryClient();
const [isEditing, setIsEditing] = useState(false); const [isEditing, setIsEditing] = useState(isCreating);
const [editState, setEditState] = useState<EditState>(() => const [editState, setEditState] = useState<EditState>(() =>
isCreating ? buildCreateState() : reminder ? buildEditState(reminder) : buildCreateState() isCreating ? buildCreateState() : reminder ? buildEditState(reminder) : buildCreateState()
); );

2
frontend/src/components/todos/TodoDetailPanel.tsx
View File

@ -95,7 +95,7 @@ export default function TodoDetailPanel({
}: TodoDetailPanelProps) { }: TodoDetailPanelProps) {
const queryClient = useQueryClient(); const queryClient = useQueryClient();
const [isEditing, setIsEditing] = useState(false); const [isEditing, setIsEditing] = useState(isCreating);
const [editState, setEditState] = useState<EditState>(() => const [editState, setEditState] = useState<EditState>(() =>
isCreating ? buildCreateState(createDefaults) : todo ? buildEditState(todo) : buildCreateState() isCreating ? buildCreateState(createDefaults) : todo ? buildEditState(todo) : buildCreateState()
); );