UMBRA

History

Kyle Pope 66cc1a0457 Action QA findings: refactor sync to accept resolved values

C-01: sync_birthday_to_contacts now accepts (share_birthday, date_of_birth)
      directly — no internal re-query, no stale-read risk with autoflush.
W-01: Eliminated redundant User/Settings SELECTs inside the service.
W-02: Removed scalar_one() on User query (no longer queries internally).
W-03: Settings router only syncs when share_birthday value actually changes.
S-02: Added logger.info with rowcount for observability.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

2026-03-07 06:13:21 +08:00

jobs

Fix QA review findings: 3 critical, 5 warnings, 1 suggestion

2026-03-06 23:41:08 +08:00

models

Fix remaining QA warnings: lazy=raise on CalendarMember + bidirectional connection check

2026-03-06 23:45:10 +08:00

routers

Action QA findings: refactor sync to accept resolved values

2026-03-07 06:13:21 +08:00

schemas

Fix QA review findings: 3 critical, 5 warnings, 1 suggestion