UMBRA

History

Kyle Pope e57a5b00c9 Fix QA review findings: C-01 through C-04, W-01 through W-07, S-01/S-04/S-05/S-06

Critical fixes:
- C-01: Pass user_id to _mark_sent/_already_sent (ntfy crash)
- C-02: Align frontend HTTP methods with backend routes (PATCH->PUT,
  DELETE->POST, fix reset-password/enforce-mfa/disable-mfa paths)
- C-03: Add X-Requested-With to CORS allow_headers
- C-04: Replace scalar_one_or_none with func.count for auth/status

Warning fixes:
- W-01: Batch audit log into same transaction in create_user, setup, register
- W-02: Extract users array from UserListResponse wrapper in useAdminUsers
- W-03: Update password hint from "8 chars" to "12 chars" in CreateUserDialog
- W-04: Remove password input from reset flow, show returned temp password
- W-06: Remove unused actor_alias variable in admin_dashboard
- W-07: Resolve usernames in dashboard audit entries via JOIN, remove
  ip_address column from recent_logins (not tracked on User model)

Suggestions applied:
- S-01/S-06: Add extra="forbid" to all admin mutation schemas
- S-04: Add ondelete="SET NULL" to audit_log.actor_user_id FK
- S-05: Improve registration error message for better UX

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

2026-02-26 19:19:04 +08:00

jobs

Fix QA review findings: C-01 through C-04, W-01 through W-07, S-01/S-04/S-05/S-06

2026-02-26 19:19:04 +08:00

models

Fix QA review findings: C-01 through C-04, W-01 through W-07, S-01/S-04/S-05/S-06

2026-02-26 19:19:04 +08:00

routers

Fix QA review findings: C-01 through C-04, W-01 through W-07, S-01/S-04/S-05/S-06

2026-02-26 19:19:04 +08:00

schemas

Fix QA review findings: C-01 through C-04, W-01 through W-07, S-01/S-04/S-05/S-06