rohskiddo/UMBRA
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Fix issues from QA review: cache invalidation, model server_default, route comment

Browse Source 
- Add ['tracked-tasks'] cache invalidation to toggle mutations in
  ProjectDetail and ProjectCard so dashboard widget stays fresh
- Add server_default=sa.false() to model for consistency with migration
- Add route ordering comment above /tracked-tasks endpoint

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Kyle 2026-02-23 03:07:06 +08:00
parent 819a4689b8
commit bb87bd3743
4 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
backend/app/models/project.py
View File

@ -1,3 +1,4 @@
import sqlalchemy as sa
from sqlalchemy import Boolean, String, Text, Date, func from sqlalchemy import Boolean, String, Text, Date, func
from sqlalchemy.orm import Mapped, mapped_column, relationship from sqlalchemy.orm import Mapped, mapped_column, relationship
from datetime import datetime, date from datetime import datetime, date
@ -14,7 +15,7 @@ class Project(Base):
status: Mapped[str] = mapped_column(String(20), default="not_started") status: Mapped[str] = mapped_column(String(20), default="not_started")
color: Mapped[Optional[str]] = mapped_column(String(20), nullable=True) color: Mapped[Optional[str]] = mapped_column(String(20), nullable=True)
due_date: Mapped[Optional[date]] = mapped_column(Date, nullable=True) due_date: Mapped[Optional[date]] = mapped_column(Date, nullable=True)
is_tracked: Mapped[bool] = mapped_column(Boolean, default=False) is_tracked: Mapped[bool] = mapped_column(Boolean, default=False, server_default=sa.false())
created_at: Mapped[datetime] = mapped_column(default=func.now()) created_at: Mapped[datetime] = mapped_column(default=func.now())
updated_at: Mapped[datetime] = mapped_column(default=func.now(), onupdate=func.now()) updated_at: Mapped[datetime] = mapped_column(default=func.now(), onupdate=func.now())

1
backend/app/routers/projects.py
View File

@ -58,6 +58,7 @@ async def get_projects(
return projects return projects
# This route MUST be defined before /{project_id} to avoid path parameter shadowing
@router.get("/tracked-tasks", response_model=List[TrackedTaskResponse]) @router.get("/tracked-tasks", response_model=List[TrackedTaskResponse])
async def get_tracked_tasks( async def get_tracked_tasks(
days: int = Query(7, ge=1, le=90), days: int = Query(7, ge=1, le=90),

1
frontend/src/components/projects/ProjectCard.tsx
View File

@ -42,6 +42,7 @@ export default function ProjectCard({ project }: ProjectCardProps) {
}, },
onSuccess: () => { onSuccess: () => {
queryClient.invalidateQueries({ queryKey: ['projects'] }); queryClient.invalidateQueries({ queryKey: ['projects'] });
queryClient.invalidateQueries({ queryKey: ['tracked-tasks'] });
toast.success(project.is_tracked ? 'Project untracked' : 'Project tracked'); toast.success(project.is_tracked ? 'Project untracked' : 'Project tracked');
}, },
onError: () => { onError: () => {

1
frontend/src/components/projects/ProjectDetail.tsx
View File

@ -196,6 +196,7 @@ export default function ProjectDetail() {
onSuccess: () => { onSuccess: () => {
queryClient.invalidateQueries({ queryKey: ['projects'] }); queryClient.invalidateQueries({ queryKey: ['projects'] });
queryClient.invalidateQueries({ queryKey: ['projects', id] }); queryClient.invalidateQueries({ queryKey: ['projects', id] });
queryClient.invalidateQueries({ queryKey: ['tracked-tasks'] });
toast.success(project?.is_tracked ? 'Project untracked' : 'Project tracked'); toast.success(project?.is_tracked ? 'Project untracked' : 'Project tracked');
}, },
onError: () => { onError: () => {